feat: prune old, inactive paths #3666
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't want to remove the metrics plumbing, but it is currently unused. So emit a single metric for now. Need to do a proper metrics review later, we need more metrics than this.
Turns out we don't do anything with those. We only use this to decide to check if we need to holepunch again. This calls trigger_holepunching for every connection event which will wake it up too much, because we only really need to do it for the connection we are using to holepunch. But the state tracking is easier like this and the cost probably not too high.
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3666/docs/iroh/ Last updated: 2025-11-23T13:39:20Z |
ramfox
changed the title
it's something, if not much
not sure how bad or good this is yet, but it compiles
matheus23
reviewed
Nov 20, 2025
ramfox
changed the base branch from
feat-multipath
to
feat-multipath-quic-nat
Member
Author
|
@flub can I merge into |
added 11 commits
November 23, 2025 14:37
…` method, and called it whenever new paths are added
…unched this connection
matheus23
approved these changes
Nov 25, 2025
Member
matheus23
left a comment
matheus23
left a comment
There was a problem hiding this comment.
With the previous comments addressed, this is good to go from my side.
Sorry that I effectively blocked this so long that we ended up with a bigger merge conflict :S
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prune paths that are not actively being used, never have been holepunched, are not about to be dialed, or old.
Notes and Questions
The logic of gathering all of the relevant information is in the
fn prune_ip_pathsfunction, not in theself.prune_ip_pathsmethod onEndpointActorState. Separating these out made it easier to test.Used AI to help write tests & reduce allocations when working through the paths.
keep_pathis where we can play around with what exactly we want to keep, based on thePathState, if we want to get more strict or particular as we learn more.I added a
PathState::holepunchedfield that says whether or not that path was ever hole punched.I added an
Instantto thePathState::sent_pingfield, so we can ensure that we don't prune paths that are currently attempting to holepunch, giving a very generous 30 seconds before deciding that the holepunch didn't work.Right now we:
This means:
Also, we only do prune this if there are more that 20 inactive paths open.
I've added
prune_ip_pathsevery time we call insert theEndpointActorState::paths.